Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Temporary disable KServe Python tests that may fail #7949

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kthui
Copy link
Contributor

@kthui kthui commented Jan 17, 2025

What does the PR do?

Disable all tests on test_kserve.py that may fail. This change is temporary to reduce false failure on the CI and it will be properly fixed with DLIS-7735.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

triton-inference-server/core#426

Where should the reviewer start?

N/A

Test plan:

N/A

  • CI Pipeline ID: See the related core PR for pipeline ID.

Caveats:

N/A

Background

gRPC library does not play well when it is forked, which will happen when a Python model is loaded, so disabling all tests that involve starting the server to prevent loading a Python model after the gRPC library is imported.

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

N/A

@kthui kthui added the PR: ci Changes to our CI configuration files and scripts label Jan 17, 2025
@kthui kthui self-assigned this Jan 17, 2025
@kthui kthui marked this pull request as ready for review January 17, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: ci Changes to our CI configuration files and scripts
Development

Successfully merging this pull request may close these issues.

1 participant